lwnbd: sync with lwnbd repo

[bignaux]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

• true inheritance according to https://github.com/QuantumLeaps/OOP-in-C/ paper
• lwNBD has linux support, allow developer to improve core faster.
• general improvement, like NBD_OPT_LIST, step to fix NBD_FLAG_FIXED_NEWSTYLE

[rickgaiser]

You seem to make a lot of changes after creating the PR. Is this a draft or is the code ready for review/merging?

PS: Perhaps it's time to move lwNBD into ps2sdk or ps2sdk-ports ? Having it in one of those repositories makes lwNBD usable in all ps2 projects. @fjtrujy any thoughts on where this code would be best suited?

[bignaux]

I just continue to fix stuff and test it, i prefer to push time to time. A bit too soon to move into ps2sdk, i'd prefer spend time to fix the protocol first, then the interface/API . I try to keep the core minimalist right now, so it's not so much file in OPL anyway.

[rickgaiser]

I browsed through your changes. I trust they are ok, since you're the creator of this subproject and becouse I like the structured way you code (OOP-in-C) :-).

I'll hit the merge button if you say it's ready.
Please check the codacy issues.

[fjtrujy]

Please anyway, if you don't mind, make an effort and move it (in a near future) to the Ps2sdk it is a really nice feature.
Thanks

[bignaux]

@rickgaiser Yeah , OOP here is a bit what you do on bdm, except i use inheritance documented in the pdf, to force me to have a codingstyle standard on that stuff, this guys knows what they wrote. I'm ok for the merge, say me if you prefer big commit or time to time as i did here, to not have user complain about stuff already fixed, and less work for reviewer. As you wish guy, i now look to have SIF RPC like other lwip ported server. It would allow me to start lwnbd with some export, or in read-only, without have to do some big reset only needed when write operation on device are necessary.

@fjtrujy : need a LOOOOOT of work before, but perhaps, someday. Initially i thought to send that to lwip mainstream, but that's became a too big project to land there. BTW, if someone is interesting to have nbd feature on other thing as OPL, he could contact me and help to the job, for now, that would be a bit useless to spend time on that.

[rickgaiser]

I'm ok for the merge

Ok, merging.

say me if you prefer big commit or time to time as i did here, to not have user complain about stuff already fixed, and less work for reviewer.

The PR must have some use I guess, like:

• Fix bug
• Add feature
• Improve performance

Those are always welcome.
But if it's sync/cleanups/restructuring only, I would prefer to not get too many in a short period of time.