gui: swap out device icon and text as new block device detected

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

Last one from me for a little while, while looking at MCs & DIR I accidentally figured out what I was doing wrong here earlier.. so might as well finish it.

The BDM Icon and text will now be rendered in the gui for usb/ilink/mx4sio depending on which device is detected.. should work when hot swapping etc but unfortunately I only have usb to test with atm..

To maintain theme compatibility the icons are as follows

BDM: usb.png
USB: usb_bd.png
ILINK: ilk_bd.png
MX4SIO: m4s_bd.png

so themes can add the separate block device icons if they want.

[KrahJohlito]

@rickgaiser I think this is good, but if there are any issues let me know and I'll just close it for now and come back to it when I can spend more time for testing etc

[J013k]

Nice.
Before connecting any BDM device:

When I start a (USB) device:

Will we need to translate additional strings for this? E.g. USB Games, FireWire...

[gledson999]

This is awesome, update, @J013k We need update all language too

String 282: USB Games
String 283: FireWire Games
String 284: MX4SIO Games.

I will update my translation when this commit is merged!

I'll update my themes and put this images too, I'm very excited with the success of mx4sio and about every update of OPL.

BDM: usb.png
USB: usb_bd.png
FIREWIRE: ilk_bd.png
MX4SIO: m4s_bd.png

[KrahJohlito]

just forgot to update the firewire gfx..thought i did it ages ago, we decided to have the text in the graphic as FW, since that will match the other icons BDM/USB/SD/FW/UDP/IDE/SMB/APPS .. iLink just looked out of place, this is now ready for review

[rickgaiser]

To make the FireWire/iLink/IEEE1394 more consistent, I think we should only use 1 version:

• iLink / ILINK / ILK

Can you change the following?:

• _STR_FIREWIRE_GAMES -> _STR_ILINK_GAMES
• FIREWIRE_ICON -> ILINK_ICON
• "FireWire Games" -> "iLink Games"

The rest of these changes look good. Thank you.

EDIT: I see we're posting conflicting messages at the same time. I don't really care about the exact name, as long as it's consistent.

See: https://en.wikipedia.org/wiki/IEEE_1394
"It was developed in the late 1980s and early 1990s by Apple in cooperation with a number of companies, primarily Sony and Panasonic. Apple called the interface FireWire. It is also known by the brands i.LINK (Sony)"

I'm not sure what the name should be now... even ps2sdk is not consisten, naming it both iLink and IEEE1394:
https://github.com/ps2dev/ps2sdk/tree/master/iop/iLink

[KrahJohlito]

To make the FireWire/iLink/IEEE1394 more consistent, I think we should only use 1 version:

• iLink / ILINK / ILK

Can you change the following?:

• _STR_FIREWIRE_GAMES -> _STR_ILINK_GAMES
• FIREWIRE_ICON -> ILINK_ICON
• "FireWire Games" -> "iLink Games"

The rest of these changes look good. Thank you.

I agree with consistency, currently in the GUI its FireWire when enabling and I like that for the acronym (FW) just because it matches the rest but reading your edit.. yea I'm not sure which to use either..

Most places I called it FireWire, I think its just the png file itself and the modules that are different..oh and BDM_ILK_MODE.. your call

[rickgaiser]

Most places I called it FireWire, I think its just the png file itself and the modules that are different..oh and BDM_ILK_MODE.. your call

It's many places actually:

• ps2sdk uses IEEE1394 and iLink, but not FireWire.
• what I added to OPL all use IEEE1394 and iLink, but not FireWire.
• the texture/image also uses iLink (both filename and image): https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/gfx/ilk_bd.png
• The actual port on your ps2 has the "i." i.LINK logo

So I think it's best keep it at iLink/i.LINK/ILINK/ILK. If you can change those I'll merge the PR.

[KrahJohlito]

Yea sorry I was just talking about within the gui in OPL (not sdk) I referred to it as FW mostly gEnableFW for example https://github.com/ps2homebrew/Open-PS2-Loader/search?q=gEnableFW&type= And this PR changes the image text to be FW..

I can change all this, probably makes more sense since this is a Sony console to be iLink going by the info you provided. Thanks

[rickgaiser]

Thanks, merging.