Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSD Language configuration #724

Merged
merged 2 commits into from Aug 14, 2022
Merged

OSD Language configuration #724

merged 2 commits into from Aug 14, 2022

Conversation

israpps
Copy link
Member

@israpps israpps commented Aug 11, 2022 •
edited

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

Changes done to the UI:

  • Added all necessary code to implement the configurations of the new feature
  • the new feature passes to EE_core all the parameters needed to respond to hooked calls of config param getter/setter
  • if feature is not enabled, the data is still passed, but no hooking is performed.
  • the struct holding the parameters is populated with the actual system configuration before loading EE Core
  • when the feature is enabled, the EE Core reports the passed parameters on a separated DPRINTF()
  • Changed the code that handles spacing on GAME_SAVE_CHANGES & GAME_REMOVE_CHANGES (menusys.c:1028)

israpps added a commit to israpps/Open-PS2-Loader-lang that referenced this pull request Aug 12, 2022
@israpps
add ps2homebrew/Open-PS2-Loader#724 Lang
01ee8f1
@israpps
Copy link
Member Author

israpps commented Aug 12, 2022

Tested Games:

Bakugan @ SLES_555.79
Spider-man 3 @ SLES_547.24
Crash M.O.M @ SLES_552.04

Tested consoles

SCPH-39001
SCPH-37000B
SCPH-50001
SCPH-90001
SCPH-18000

Tested the following two scenarios:

  1. enforce a language supported by the console, but not set
  2. enforce a language unsupported by the console

Both tests yielded excellent results, tests were performed on those games, across all consoles, on mx4sio (and HDD on the expansion bay units of the list)

@israpps israpps marked this pull request as ready for review August 12, 2022 02:15
KrahJohlito
KrahJohlito suggested changes Aug 13, 2022
View reviewed changes
Copy link
Member

@KrahJohlito KrahJohlito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm nice one, couple small things though.

include/config.h Outdated Show resolved Hide resolved
src/guigame.c Show resolved Hide resolved
src/guigame.c Outdated Show resolved Hide resolved
@israpps
Copy link
Member Author

israpps commented Aug 13, 2022

Lol, I did not realize

uyjulian
uyjulian reviewed Aug 13, 2022
View reviewed changes
src/guigame.c Outdated Show resolved Hide resolved
@israpps israpps requested a review from uyjulian August 13, 2022 21:20
AKuHAK
AKuHAK requested changes Aug 14, 2022
View reviewed changes
lng_tmpl/_base.yml Outdated Show resolved Hide resolved
src/menusys.c Show resolved Hide resolved
KrahJohlito
KrahJohlito reviewed Aug 14, 2022
View reviewed changes
Copy link
Member

@KrahJohlito KrahJohlito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These last couple things are really just nit picky and more so general clean up but hopefully you find it helpful, good work mate

ee_core/include/ee_core.h Outdated Show resolved Hide resolved
ee_core/src/main.c Outdated Show resolved Hide resolved
src/guigame.c Outdated Show resolved Hide resolved
src/system.c Outdated Show resolved Hide resolved
@israpps israpps force-pushed the osd-config branch 6 times, most recently from 575e557 to 4b908ec Compare August 14, 2022 15:49
@israpps
Copy link
Member Author

israpps commented Aug 14, 2022

Fortunately Github Desktop made the rebase ridiculously easy

@AKuHAK
Copy link
Member

AKuHAK commented Aug 14, 2022

Looks good

uyjulian
uyjulian approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@uyjulian uyjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK

KrahJohlito
KrahJohlito approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@KrahJohlito KrahJohlito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mate

@israpps
Copy link
Member Author

israpps commented Aug 14, 2022

Nice

Who merges?

@uyjulian uyjulian merged commit 3e26d1f into ps2homebrew:master Aug 14, 2022
uyjulian added a commit to ps2homebrew/Open-PS2-Loader-lang that referenced this pull request Aug 14, 2022
@uyjulian
Merge pull request #2 from israpps/OSDLNG
282e7e3 
add ps2homebrew/Open-PS2-Loader#724 Lang
@gcb2008
Copy link

gcb2008 commented Aug 15, 2022

Loading Chinese fonts will get stuck. Model 30000

@israpps israpps deleted the osd-config branch August 15, 2022 17:35
@rickgaiser rickgaiser mentioned this pull request Apr 17, 2023
Closed
2 tasks
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@uyjulian
Merge pull request ps2homebrew#724 from israpps/osd-config
4f74302 
OSD Language configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKuHAK AKuHAK AKuHAK approved these changes

@uyjulian uyjulian uyjulian approved these changes

@KrahJohlito KrahJohlito KrahJohlito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@israpps @AKuHAK @gcb2008 @uyjulian @KrahJohlito