Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse launch args to auto launch bdm games #852

Merged
merged 2 commits into from Dec 20, 2022

Conversation

KrahJohlito
Copy link
Member

@KrahJohlito KrahJohlito commented Dec 19, 2022

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

This will allow auto launching BDM games by sending a few args:

 argv[1] file name (including extension)
 argv[2] game->startup
 argv[3] game->media ("CD" / "DVD")
 argv[4] “bdm”

I could only test the USB side of BDM since I don’t have an iLink drive or an MX4SIO but in theory they should also work fine… not sure if I should squash commits either.

@KrahJohlito KrahJohlito marked this pull request as ready for review December 19, 2022 08:39
Copy link
Member

@uyjulian uyjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance, lgtm

@KrahJohlito
Copy link
Member Author

Gotta push a 2 line update after work.. forgot to remove unused variable in the clean up

@KrahJohlito
Copy link
Member Author

Alright that’s defo done

@uyjulian uyjulian merged commit 26f5fe7 into ps2homebrew:master Dec 20, 2022
@KrahJohlito KrahJohlito deleted the autobdm branch December 23, 2022 06:59
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
parse launch args to auto launch bdm games
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants