semaphore max value

[kazzmir]

In SDL/src/thread/psl1ght/SDL_syssem.c:SDL_CreateSemaphore a call is made to sysSemCreate where the 4th parameter is the initial value. The 4th parameter controls the maximum value the semaphore can have.

sysSemCreate( &sem->id, &attr, initial_value, initial_value);

The initial value should not be the limit of semaphores since SDL itself sometimes creates semaphores with an initial value of 0.
SDL/src/thread/SDL_thread.c:250 in SDL_CreateThread

args->wait = SDL_CreateSemaphore(0);

The solution is to use some large value for the maximum value. I used 99 but maybe there is some better default value.

 sysSemCreate( &sem->id, &attr, initial_value, 99);

Note that without this fix the following error occurs frequently:
sysSem[Try]Wait() failed

You can see this by using a very simple test case

int test(void * arg){
  return 0;
}

int main(){
  SDL_Init();
  SDL_CreateThread(test, NULL);
}

[zeldin]

Issue opened on the wrong repository. Also, fixed. :-)