Skip to content
This repository has been archived by the owner on Feb 9, 2018. It is now read-only.

Commit

Permalink
CHANGELOG updated
Browse files Browse the repository at this point in the history
  • Loading branch information
@ikarsokolov
ikarsokolov committed Nov 10, 2012
1 parent 27c7c1a commit ceb4f68
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.txt
View file
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Changelog:


1.71.1 - 2012-??-?? 1.71.1 - 2012-??-??
- Fixed bug that occurred when using ShowDVDTitleDuration - Fixed bug that occurred when using ShowDVDTitleDuration
- Disabled internal switching to TSMuxeR from other transcoding engines. Select the one you want from TRANSCODE folder.


1.71.0 - 2012-11-06 1.71.0 - 2012-11-06


Expand Down

12 comments on commit ceb4f68

@ExSport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One biggest flaw of this removal is that you will miss playing MKV files outside TRANSCODE folder with remuxing when subs are not needed. But when subs should be used depending on preference settings, PMS should automatically switch to MEnocoder.
This behavior was easily doable by using [MEncoder] engine at the top in preferrence order.
After removal of this feature when MEncoder will be 1st, MEncoder will be used so bandwidth and CPU will be wasted when no subs will be present.
When tsMuxeR will be 1st, audio/subs preference will be ignored so noone will know if subs are present and should be used. So every time you have to go inside TRANSCODE folder and check present subs and audio tracks and choosing correct one manually.
So we will loose possibility to play MKV files easily without going to TRANSCODE folder and playing it automatically depending on audio/video preference.
I know this option change the logic so preferred MEncoder will not be used when this option [remux when possible] is enabled but the name of this option say it exactly what will happen.
I think this removal will do more bads than pros. All will lose forced subs, audio/sub priority without going to TRANSCODE folder what is not user friendly.

@lightglitch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also notice this change and don't understand why it was removed.

@Raptor399
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the removal was inspired by this post, correct me if I'm wrong.

@ExSport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can talk about Win only but tsMuxeR never was problem for me and in forums I didn't spotted it is a known flaw.
If it is a problem of the OSX systems (the minority), why is it applied to all? This removal more takes than gives so if some platform has problems with it, default option to disable it is a good way:-)
Or if removed for all, make another changes which will get back missing features and behaviors by this removal in another way.
Only my thoughts:-)

@ikarsokolov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross engine dependencies are undesirable. If engine absolutely have to use capabilities provided by another one it should do it internally without any confusing GUI config options through clearly defined API.

Default H.264 Remux with MEncoder was fundamentally broken workaround for absence of engines priority system causing presence of unrelated code in MEncoderVideo.java => numerous bugs. Not to mention misleading naming: it has nothing to do with mencoder therefore has no reason to be on mecoder's GUI page.

Right now we have single "default engine" system with ability to override choice on case by case basis through TRANSCODE folder. It is simple and elegant solution which users should learn to use. Proper context aware priority system with ability to choose default engine based on file type and renderer capabilities should be developed if we want to add more convenience to this process. Ugly workarounds messing with core logic is not the way to go.

@ExSport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then why we have here forced subs, Audio/Sub priority which should automatically play preferred combination?
We loose it with this removal. We have 4 choices (with MKV):

  • use tsMuxeR engine with lowest bitrate but without working subs and audio/sub priority(audio tracks are not reordered upon preferences).
  • use MEncoder engine so we will waste CPU and bandwidth when subs are not present/needed
  • going to TRANSCODE folder everytime - waste time and complicate it for older/non "technical" people
  • use older version without this patch so file will be played exactly upon defined preference (without manual check of TRANSCODE folder)

TRANSCODE folder should be used for special cases when automatic audio/subs/engine will not do correct choose so we will need to go there to play file at all or with preferred audio/subs.
If we should learn going to TRANSCODE folder everytime when we will play MKV, ok, but I don't think it is a good way.
The magic without this removal is that nobody should know if subs are present or not, if forced subs should be played etc. Everything was done automatically and upon it video was played with best settings.
In PMS code there are so many hacks but they are there because without them PMS will just don't work and if they are removed, it is fixed by another additional, cleaner code. This removal will maybe remove hack, but without the fix for things which will broke (audio/sub/forced_subs choosing algorithm) after that, removal should wait.
Maybe it seems I am alone but hopefully I am not. With new version published we will see. My opinion is it is a big step back.

@ikarsokolov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand you.

Everything is configurable as it is. You can set tsmuxer engine on top priority and everything will be played with it by default. It does not support subtitles at all so if you need them for particular file just select mencoder (or other engine) through TRANSCODE folder. And it will honour your preferred audio and subtitle language settings.

There is no magic here, PS3MS can't read your mind and decide whether or not you want subtitles and what exact track to play.

@ExSport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't understand me.
Without this patch there is a easy way how to play file with preferred audio and preferred subs without going to TRANSCODE folder and choosing it manually. When I will choose tsMuxeR, as you said I have to go to TRANSCODE folder and do manual choose. Why PMS can't do it automatically upon my settings?
When I move MEncoder to the top of priority, it will automatically play forced or full subs when needed with correct audio(upon preference). The flaw is that it also use MEncoder (I know it is top priority engine so it is logical) when it is not needed and many users use it only when needed==>when they want subs or file doesn't play via tsMuxeR.
For both cases you have to go TRANSCODE folder anyway. Why? Because when tsMuxeR is used, you go there to check if there are subs which should be played or not.
Same for MEncoder, you need to check TRANSCODE folder if there are any subs and if not, why not to use tsMuxeR?
So everytime you need to go to TRANSCODE folder and make manual choose (loosing the ability of PMS to set audio/video preference)
God light shined on me....what about to create new engine e.g. "MuxMenc" which will do what old versions does. It will choose txMuxeR and when full/forced subs are detected, it will switch automatically to MEncoder because for subs it is only solution.
You will have your pure MEncoder and tsMuxeR engine with no hacks and then new engine which will be combination of both => the only unique feature which PMS has facing to other DLNA servers. It is a main feature why I am using PMS....also because of that I programmed this forced subs algorithm in past;-)
Thx
P.S.
And about your last sentence....just kidding?:-) What do you think does this combo:

  • make MEncoder as default engine
  • enable "Switch to tsMuxeR when MEncoder not needed"
  • set Audio/Sub preference
  • define "forced" string

This will do the magic, it will read my mind (depending on audio/video preference), read the MKV file+external subs, read audio and subtitle language tags and choose correct combination. If native audio is found, no subs are played except forced ones(if found) and if no native audio found, native full subs are played. So nothing magical:-)

@ikarsokolov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now language priority is per-engine setting. It simply sets what tracks engine should play by default. And it still works for mencoder like before. For tsmuxer we don't have it but you can choose to mux all audio tracks and select the one you need from player.

I think you are confused by assumption that it has something to do with core engine selection logic but it does not. Completely separate issue.

@lightglitch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, before removing this feature, we should implement an intelligent engine chooser that can imitate this feature.

Because what like of this feature is to have the following behavior without using the transcode folder:

If is compatible with ps3 and doesn't have subtitles use tsmuxer - no need of transconding
if it is not compatible or have subtitles then use mencoder

I like that pms is smart enough so that I don't have to go to the transcode folder for each option.

@ikarsokolov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should continue engine priority system discussion in forum and consider all possible options.
However this workaround is gone.

@ExSport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.ps3mediaserver.org/forum/viewtopic.php?f=4&t=15785

Please sign in to comment.