Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Psalm 4.21 compatibility #39

Closed
wants to merge 3 commits into from
Closed

Fix Psalm 4.21 compatibility #39

wants to merge 3 commits into from

Conversation

mzur
Copy link

@mzur mzur commented Feb 21, 2022

totallyTyped was deprecated in Psalm v4.21.0. From the docs: totallyTyped="true" is equivalent to errorLevel="1".

@weirdan weirdan closed this Feb 21, 2022
@weirdan weirdan reopened this Feb 21, 2022
@weirdan
Copy link
Member

weirdan commented Feb 21, 2022

There are two more places where totallyTyped is used: https://github.com/psalm/codeception-psalm-module/search?q=totallyTyped

Mind fixing them as well?

@mzur
Copy link
Author

mzur commented Feb 21, 2022

Sorry, I missed these. Strange that the tests passed for me locally regardless 🤔

@mzur mzur requested a review from weirdan February 21, 2022 11:45
@weirdan
Copy link
Member

weirdan commented Feb 21, 2022

Perhaps it makes sense to bump the minimum Psalm version to whichever introduced the errorLevel attribute.

@mzur
Copy link
Author

mzur commented Feb 21, 2022

Looks like this would be v3.9.0.

@mzur
Copy link
Author

mzur commented Feb 21, 2022 •
edited

Looks like there is still some issue with the test suite. I tested locally with "low deps" and while I had to upgrade squizlabs/php_codesniffer to ^3.5 for PHP 8 compatibility, the tests passed. But they passed for my first commit, too, so 🤷‍♂️

@tm1000 tm1000 mentioned this pull request Apr 27, 2022
Merged
@tm1000
Copy link

tm1000 commented Apr 27, 2022

@mzur the error is Cannot find file phpvfscomposer:/home/runner/work/codeception-psalm-module/codeception-psalm-module/vendor/vimeo/psalm/psalm to include It seems like the runner got corrupted. @orklah can you close and reopen this PR?

@orklah
Copy link

orklah commented Apr 27, 2022

I should be able to but I can't. @muglug can you give me some permissions for this repo?

@weirdan weirdan closed this Apr 27, 2022
@weirdan weirdan reopened this Apr 27, 2022
@weirdan
Copy link
Member

weirdan commented Apr 27, 2022

@tm1000 reopen doesn't trigger jobs, it requires a new push.

@tm1000
Copy link

tm1000 commented Apr 27, 2022

Still fails with Cannot find file phpvfscomposer:/home/runner/work/codeception-psalm-module/codeception-psalm-module/vendor/vimeo/psalm/psalm which is really strange

@weirdan
Copy link
Member

weirdan commented Dec 2, 2022

I believe this has already been fixed on the master branch.

@weirdan weirdan closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan Awaiting requested review from weirdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzur @weirdan @tm1000 @orklah