[Math] don't perform operations on possible numeric-string (azjezz#220)

psalm · Jul 24, 2021 · 4895e61 · 4895e61
1 parent 46391a4
commit 4895e61
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Psl/Math/mean.php b/src/Psl/Math/mean.php
@@ -9,7 +9,7 @@
 /**
  * Return the arithmetic mean of the numbers in the given iterable.
  *
- * @param iterable<numeric> $numbers
+ * @param iterable<int|float> $numbers
  */
 function mean(iterable $numbers): ?float
 {
@@ -20,8 +20,8 @@ function mean(iterable $numbers): ?float
 
     $mean = 0.0;
     foreach ($numbers as $number) {
-        $mean += $number / $count;
+        $mean += (float)$number / $count;
     }
 
-    return (float) $mean;
+    return $mean;
 }
diff --git a/src/Psl/Math/sum_floats.php b/src/Psl/Math/sum_floats.php
@@ -7,16 +7,16 @@
 /**
  * Returns the float sum of the values of the given iterable.
  *
- * @param list<numeric> $numbers
+ * @param list<int|float> $numbers
  *
  * @pure
  */
 function sum_floats(array $numbers): float
 {
     $result = 0.0;
     foreach ($numbers as $number) {
-        $result += $number;
+        $result += (float)$number;
     }
 
-    return (float) $result;
+    return $result;
 }