🚧 expect test to fail

psalm · Jul 19, 2020 · d69377b · d69377b
1 parent 669d0c0
commit d69377b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/ReturnTypeProvider/PathHelpersReturnTypeProvider.php b/src/ReturnTypeProvider/PathHelpersReturnTypeProvider.php
@@ -2,14 +2,12 @@
 
 namespace Psalm\LaravelPlugin\ReturnTypeProvider;
 
-use PhpParser\Node\Expr\MethodCall;
 use Psalm\CodeLocation;
 use Psalm\Context;
 use Psalm\LaravelPlugin\ApplicationHelper;
 use Psalm\Plugin\Hook\FunctionReturnTypeProviderInterface;
 use Psalm\StatementsSource;
 use Psalm\Type\Atomic\TLiteralString;
-use Psalm\Type\Atomic\TNamedObject;
 use Psalm\Type\Union;
 
 final class PathHelpersReturnTypeProvider implements FunctionReturnTypeProviderInterface
@@ -20,7 +18,6 @@ final class PathHelpersReturnTypeProvider implements FunctionReturnTypeProviderI
 
     public static function getFunctionIds(): array
     {
-        return ['base_path'];
         return array_keys(self::MAP);
     }
 
@@ -41,6 +38,7 @@ public static function getFunctionReturnType(StatementsSource $statements_source
                 $argument = $argumentType->value;
             }
         }
+
         $path = ApplicationHelper::getApp()->{$appMethod}($argument);
 
         if (!$path) {

diff --git a/tests/acceptance/PathHelpers.feature b/tests/acceptance/PathHelpers.feature
@@ -29,3 +29,12 @@ Feature: path helpers
       When I run Psalm
       Then I see these errors
         | MissingFile | Cannot find file |
+
+    Scenario: basePath can be resolved from application instance
+      Given I have the following code
+      """
+      require_once app()->basePath('routes/console.php');
+      """
+      When I run Psalm
+      Then I see these errors
+        | MissingFile | Cannot find file |