New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Model template on the Builder covariant. #135

Merged

mr-feek merged 1 commit into psalm:master from twistor:builder-covariant

Mar 22, 2021

twistor commented Mar 21, 2021

Here's an example. Should be easier than explaining.

Here's the issue:
https://psalm.dev/r/6c65f643a1

Here's the fix:
https://psalm.dev/r/ffc832b680


          Make the Model template on the Builder covariant.

42449b8

Author

twistor commented Mar 21, 2021

Not sure if this is a workaround of if this is the right approach.

But this works without any of the proposed changes: https://psalm.dev/r/812a3e545c

mr-feek merged commit eed0e6f into psalm:master

Collaborator

mr-feek commented Mar 22, 2021

Thanks @twistor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment