Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore PropertyNotSetInConstructor in Console\Command, Http\FormRequest and Notifications\Notifications classes #172

Merged
merged 6 commits into from
Jul 9, 2021
Merged

fix: ignore PropertyNotSetInConstructor in Console\Command, Http\FormRequest and Notifications\Notifications classes #172

merged 6 commits into from
Jul 9, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jul 6, 2021 •
edited

@caugner
Copy link
Contributor Author

caugner commented Jul 6, 2021

Blocked by: #173 (comment)

@caugner caugner changed the title feature: Http\FormRequest support fix: ignore PropertyNotSetInConstructor in Console\Command and Http\FormRequest classes Jul 6, 2021
@caugner caugner mentioned this pull request Jul 6, 2021
Closed
@caugner caugner marked this pull request as ready for review July 6, 2021 21:14
@mr-feek
Copy link
Collaborator

mr-feek commented Jul 6, 2021

This looks really cool -- let me dig into it later today. Also sidenote -- this may get fixed upstream?! https://twitter.com/taylorotwell/status/1411752717563752449?s=19

@caugner
Copy link
Contributor Author

caugner commented Jul 6, 2021

The remaining NonInvariantDocblockPropertyType error in Laravel 7.x is an upstream issue that I fixed in Laravel 8.44.0:

laravel/framework@3062083

@mr-feek Since Laravel 7 is no longer supported (source), shouldn't Laravel 6 be tested instead?

@mr-feek
Copy link
Collaborator

mr-feek commented Jul 6, 2021

@caugner im fine with that

@caugner caugner marked this pull request as draft July 7, 2021 17:07
@caugner caugner changed the title fix: ignore PropertyNotSetInConstructor in Console\Command and Http\FormRequest classes fix: ignore PropertyNotSetInConstructor in Console\Command, Http\FormRequest and Notifications\Notifications classes Jul 7, 2021
@caugner caugner marked this pull request as ready for review July 7, 2021 17:41
@caugner caugner mentioned this pull request Jul 7, 2021
Closed
@mr-feek mr-feek added the enhancement New feature or request label Jul 9, 2021
@mr-feek mr-feek merged commit b6caca7 into psalm:master Jul 9, 2021
@mr-feek
Copy link
Collaborator

mr-feek commented Jul 9, 2021

awesome job!!!

@caugner caugner deleted the support-Http-FormRequest branch July 9, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@caugner @mr-feek