Consolidate plugin files #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-feek
commented
Apr 12, 2020
| <directory name="tests" /> | ||
| </ignoreFiles> | ||
| </projectFiles> | ||
|
|
||
| <issueHandlers> | ||
| <LessSpecificReturnType errorLevel="info" /> | ||
| </issueHandlers> | ||
|
|
||
| <stubs> | ||
| <file name="src/Stubs/LumenApplication.stubphp"/> |
There was a problem hiding this comment.
I decided to add a stub for the lumen application file, instead of requiring the lumen framework as a dependency. I assume most people using this package will be using laravel and not lumen, so I think this is acceptable
mr-feek
commented
Apr 12, 2020
| $app = (new static)->createApplication(); | ||
| } | ||
|
|
||
| if ($app instanceof \Illuminate\Contracts\Foundation\Application) { |
There was a problem hiding this comment.
I find having these two conditional statements here much more readable than splitting the logic via inheritance
mr-feek
commented
Apr 12, 2020
| $app->boot(); | ||
| } | ||
|
|
||
| $app->register(\Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider::class); |
There was a problem hiding this comment.
it should be safe to call register on all the app instances. Register exists on both the lumen application as well as the laravel application. Both seem to short circuit if getProvider is true, so we don't need to explicitly call that ourselves.
|
Mind rebasing this? |
mr-feek
force-pushed
the
consolidate-plugin
branch
from
66bf394
to
c15f1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main goal of this was to:
Everything here should be functionally the same, it is just a refactor.