Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Cleanup dependencies #35

Merged
merged 4 commits into from Apr 18, 2020
Merged

[wip] Cleanup dependencies #35

merged 4 commits into from Apr 18, 2020

Conversation

mr-feek
Copy link
Collaborator

@mr-feek mr-feek commented Apr 12, 2020 •
edited

  • More specific dependencies that we actually rely on (or will soon as we add full Laravel support)
  • A test matrix for testing various versions

@muglug
Copy link
Member

muglug commented Apr 14, 2020

Why the 7.2 requirement?

@mr-feek
Copy link
Collaborator Author

mr-feek commented Apr 14, 2020

No strong reason at all, I just used what my project was using. Shall we drop down to "php": "^7.1.3|^8", like psalm?

@muglug
Copy link
Member

muglug commented Apr 14, 2020

Yes please!

@mr-feek mr-feek force-pushed the cleanup-dependencies branch 2 times, most recently from c05358b to 845ce6b Compare April 18, 2020 07:21
@mr-feek mr-feek changed the title Cleanup dependencies [wip] Cleanup dependencies Apr 18, 2020
@muglug muglug merged commit c6e5a59 into psalm:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mr-feek @muglug