Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External data provider reported missing when running psalm on a single test file #57

Closed
weirdan opened this issue Mar 29, 2020 · 1 comment · Fixed by #58
Closed

External data provider reported missing when running psalm on a single test file #57

weirdan opened this issue Mar 29, 2020 · 1 comment · Fixed by #58
Assignees
@weirdan
Labels
bug Something isn't working

Comments

@weirdan
Copy link
Member

weirdan commented Mar 29, 2020

Reported in vimeo/psalm#2191 (comment)
To reproduce:

  1. Reference external data provider
  2. Run psalm on the individual test file

/cc: @localheinz
@weirdan weirdan self-assigned this Mar 29, 2020
@weirdan weirdan added the bug Something isn't working label Mar 29, 2020
weirdan added a commit to weirdan/phpunit-psalm-plugin that referenced this issue Mar 30, 2020
@weirdan
Store external dataprovider references in afterClassLikeVisit
8f98135 
This fixes false-positive UndefinedClass issues when Psalm is run on a
single test file with cold cache.

Fixes psalm#57
@weirdan weirdan mentioned this issue Mar 30, 2020
Merged
@localheinz
Copy link

Thank you, @weirdan!

Can confirm that this works now for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weirdan weirdan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix external dataproviders when psalm runs on a single file weirdan/phpunit-psalm-plugin
2 participants
@weirdan @localheinz