assume service as public if public attribute is missing (#15)

psalm · Mar 15, 2020 · c2b2dd4 · c2b2dd4
1 parent 007d3c6
commit c2b2dd4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/Symfony/ContainerMeta.php b/src/Symfony/ContainerMeta.php
@@ -33,7 +33,7 @@ public function __construct(string $containerXmlPath)
             if (isset($serviceAttributes->alias)) {
                 $service->setAlias((string) $serviceAttributes->alias);
             }
-            $service->setIsPublic('true' === (string) $serviceAttributes->public);
+            $service->setIsPublic('false' !== (string) $serviceAttributes->public);
 
             $this->add($service);
         }

diff --git a/tests/acceptance/container.xml b/tests/acceptance/container.xml
@@ -16,5 +16,6 @@
         <service id="Symfony\Component\HttpKernel\HttpKernelInterface" alias="http_kernel" public="true"/>
         <service id="Foo\Bar" class="Foo\Bar" public="false"/>
         <service id="private_service" class="Foo\Bar" public="false"/>
+        <service id="public_service_wo_public_attr" class="Foo\Bar"/>
     </services>
 </container>
diff --git a/tests/unit/Symfony/ContainerMetaTest.php b/tests/unit/Symfony/ContainerMetaTest.php
@@ -57,6 +57,11 @@ public function publicServices()
                 'className' => 'Symfony\Component\HttpKernel\HttpKernel',
                 'isPublic' => true,
             ],
+            [
+                'id' => 'public_service_wo_public_attr',
+                'className' => 'Foo\Bar',
+                'isPublic' => true,
+            ],
         ];
     }