Allow absolute config paths #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ilyes512 I like the changes, but we had to merge some other stuff in and it looks like it caused a merge conflict. Do you think you could pull in the latest changes in master and apply your update again? Thanks! |
|
Well, it would have been nice to merge PR's in historical order and more so if the MR that caused the merge conflict was yours. I guess it was a nicer feature to have. I will update this MR soon and let you know. |
Thanks, and sorry for my out-of-order merging |
|
I've ended up resolving this in a different way in the 2.x release since everything depends on the workspace you are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using this plugin with "Remote Containers"-extension without success. It couldn't find the
psalm.xmlfile. The file was not in the root of the workspaceFolder but one down (in${workspaceFolder}/src).Even after setting
psalm.configPathsI couldn't get it to work. After a few hours of digging I finally got it running by allowing setting absolute paths to the config (it will try the path as given without prefixing it with the workspaceFolderPath).I also set the
extensionKindtoworkspace. It basically means that it wants to be where the workspace (vscode-server) is installed instead of on the UI-side. More info here: doc.More info on Remote Containers here: docs.