Extended error reporting on connect #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschmitt
reviewed
Jan 6, 2024
| @@ -71,12 +71,15 @@ def connect(self): | |||
| self._open_mqtt_connection() | |||
| return True | |||
| except Exception as e: | |||
| _last_error = "Can't connect to {}, error: {}".format(self.address, e) | |||
There was a problem hiding this comment.
Why not store this as a class attribute?
There was a problem hiding this comment.
As it's only needed during connect and the value is passed to the caller by on_connect, I think it's better to leave it local.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_open_mqtt_connection does not fire on_connect if Roomba refuses connection, so that client_error will stay empty in that case.
Extended the connect method to add this scenario.