Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pydantic in favor of mashumaro #277

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Replace pydantic in favor of mashumaro #277

merged 3 commits into from
Mar 1, 2024

Conversation

Orhideous
Copy link
Collaborator

@Orhideous Orhideous commented Mar 1, 2024

Rationale

Introducing pydantic in #231 led to unnecessary maintenance burden — #232

In light of the gradual eviction of this dependency from the HA core (home-assistant/core#99218), I'd like to keep the dependency tree clean and tidy. Since this library uses only a small subset of the vast possibilities that pydantic now offers, I think it's reasonable to replace it with something faster, smaller and with more strict backwards compatibility.

So I replace pydantic with a magic mushroom.

P.S. Many thanks for @joostlek for pointing to this.

pyproject.toml Outdated Show resolved Hide resolved
@Orhideous Orhideous merged commit 3fd3d75 into main Mar 1, 2024
7 checks passed
@Orhideous Orhideous deleted the mushrooms branch March 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants