Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Classic200S #7

Closed
wphillips82 opened this issue Dec 14, 2021 · 7 comments · Fixed by #8
Closed

Add Support for Classic200S #7

wphillips82 opened this issue Dec 14, 2021 · 7 comments · Fixed by #8
Assignees
Labels
enhancement New feature or request

Comments

@wphillips82
Copy link

Can you add support for the Classic 200S

@wphillips82 wphillips82 added the enhancement New feature or request label Dec 14, 2021
@pschroeder89
Copy link
Owner

I don't own one, so I'd need to know some info about it. How many mist levels does it have? Does it have auto mode?

@pschroeder89
Copy link
Owner

pschroeder89 commented Dec 16, 2021

Hey @wphillips82, I did a quick google search and looks like it has 3 mist levels and auto mode. I've created 1.3.0-beta2 that adds support, so please test it out and let me know if things work as expected.
Thanks!

@wphillips82
Copy link
Author

Wow that was quick. Just got to test it and it actually has 9 mist levels and currently when I set Apple Home to 100% the Vesync app only shows mist level 3 out of 9.

On, Off and Auto work as expected.

@pschroeder89
Copy link
Owner

@wphillips82 I adjusted the mist level for the Classic 200s to 9 levels instead of 3, sorry bout that.
I also adjusted some logic around how the slider values are calculated per humidifier, so you should now see the slider increment by ~11% instead of 10%, since we now calculate it by (100 / the the number of mist levels).

This is all in 1.3.0-beta4 if you wouldn't mind re-testing the mist levels for the 200s. Thanks in advance!

@wphillips82
Copy link
Author

Setting the mist level works correctly now but there still appears to be a issue when Apple Home is reading the mist level back from the humidifier for just mist level 1, 2, 3 and 4.

Example
I set the mist level to 22% in Home
Go to vesync app and it shows level 2
go back to Home and now it shows 11%
Go back to vesync and it still shows level 2

For mist level 1, Home set at 11% reads it back at 0%
For mist level 2, Home set at 22% reads it back at 11%
For mist level 3, Home set at 33% reads it back at 22%
For mist level 4, Home set at 44% reads it back at 33%

This doesn't happen for mist level 5-9
For mist level 5, Home sets and reads it back at 56%
For mist level 6, Home sets and reads it back at 67%
For mist level 7, Home sets and reads it back at 78%
For mist level 8, Home sets and reads it back at 89%
For mist level 9, Home sets and reads it back at 100%

@pschroeder89
Copy link
Owner

pschroeder89 commented Dec 20, 2021

Yup, I saw that too after messing around for a while. The problem is I tried to fix something for the Dual200s at the same time, which complicated how the percentages and mist levels were calculated.

I've pushed 1.3.0-beta8 1.3.0-beta9 that simplifies the mist level logic. I have tested it a bit and haven't seen any error logs (which I was getting infrequently in previous versions), and the issue you described above isn't happening for me.

Please test if you have time. I'll continue to test on my end, too.

@wphillips82
Copy link
Author

beta9 works as expected. Tested all mist levels and switched back and forth between Homekit and Vesync and everything is correct now. Thanks alot for getting this added.

pschroeder89 added a commit that referenced this issue Dec 20, 2021
Add support for Classic200S (#6) and fix math around mist_level (#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants