Add rudimentary morse mode #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and also stroking Space characters for multiword briefs also don't get translated into slashes. |
|
Siiick, love it! I got some thoughts for tidy up on the spaces. Plan would be to extend the substitute class and return ' '.join(characters) there. I don't mind picking that up if you don't follow, let me know! The TK-LS thing I've seen before, it's definitely unrelated to your changes. Probably belongs in a separate issue |
|
Nice! Everything I've done in this PR is all I really can do (not a programmer). You can absolutely pick up from where I left off. Thanks again for this awesome plugin! |
|
Not a problem at all! Thanks for the pr! |
… multiword briefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a mode to translate text into Morse code, but it doesn't work as well as I'd hoped. Currently I have the every letter mapped to its translation in Morse and also with a space after it. This is not really ideal, but I couldn't figure out a way to put a space in between every character. I also couldn't figure out if I can change the space character between words to a slash, so currently I'm just using
{:fancytext_set:morse}{MODE:SET_SPACE:/}.I'm not sure if this is something you want to improve, but I'm opening this PR just in case it is something you're interested in.