Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare RestSharp dependency in nuspec #2

Merged
merged 1 commit into from Sep 5, 2016

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Feb 9, 2016

This pull request should fix #1. I haven't tested it because I don't own the nuget package.

The declared dependency matches packages.config.

More information on declaring dependencies in nuspec can be found in the nuget documentatoin.

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2016

@pseudomuto: are you still interested in this feature? Is there anything else you'd like to see in the pull request?

@pseudomuto

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2016

Hey @c-w, sorry for the delay, I just saw this now (since I wasn't pinged in the description). Definitely interested!

Change looks good, I'll verify it all works shortly. Thanks again for taking the time to do this

@pseudomuto

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2016

Longest. PR. Review. Ever 😄

Thanks so much for pinging me about it again...this really should be in here

@pseudomuto pseudomuto merged commit 245c2d2 into pseudomuto:master Sep 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.