Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for envoyproxy/validate extension #392

Merged
merged 3 commits into from
May 7, 2020
Merged

Bugfix for envoyproxy/validate extension #392

merged 3 commits into from
May 7, 2020

Conversation

htdvisser
Copy link
Contributor

This pull request contains a small bugfix (a single fallthrough statement) for the envoyproxy/validate extension (formerly lyft/validate) and moves it to envoyproxy_validate while keeping aliases in lyft_validate.

The bugfix is needed to make slice rules such as in and not_in work properly.

@htdvisser
Copy link
Contributor Author

Hi @pseudomuto, this pull request has been open for almost a year now, so I rebased it on top of master to get it up-to-date again. Please let me know if this is something that might get merged, otherwise I'll just close the PR.

@pseudomuto
Copy link
Owner

Hey @htdvisser so sorry for the loooong delay. In the future, please @ me on PRs so I get notified about them.

I'm good with this change 👍. Would you mind adding a line to CHANGELOG.md? Once that's done we'll get this merged and released.

@htdvisser
Copy link
Contributor Author

Hi @pseudomuto, what exactly do you want me to add to the CHANGELOG? It already contains the following lines:

  • Renamed lyft_validate extension to envoyproxy_validate
  • Fixed envoyproxy_validate rules with slice values such as in and not_in

I didn't do anything else in this pull request, so I thought that would cover it

@pseudomuto
Copy link
Owner

Whoops! Somehow I blocked the md changes from my mind 😄 Thanks for the PR man!

@pseudomuto pseudomuto merged commit 557ff76 into pseudomuto:master May 7, 2020
@pseudomuto
Copy link
Owner

Released https://github.com/pseudomuto/protoc-gen-doc/releases/tag/v1.3.2 with these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants