Trailing list/tuple literals in arguments

[flying-sheep]

One case where I consider black’s output clearly uglier than my hand-formatted output is code that looks like tree DSLs, e.g.:

thing = node("span", [
    "Some important",
    node("em", ["text"]),
    ".",
])

or similar code:

if isinstance(thing, (
    long.ClassName,
    another.long.ClassName,
)):
    ...

Both of which black would blow up into the space-consuming and in no way more clear versions with one short parameter on its own line and then the list/tuple literal after, with one more indentation level than in my version.

[blueyed]

Looks like #826 should also handle function arguments (correctly)? /cc @durin42

Note that it turns:

f(
    [
        1,
        2,
    ]
)

Into

f(
    [1, 2,]
)

(resulting in flake8 complaining about "E231 missing whitespace after ','")
black, version 19.10b1.dev5+gde6f4b1

[flying-sheep]

I think it makes sense to collapse a list/tuple/… literal like this (sans trailing comma). I think the precedence depending on line length should be (most preferred to least preferred):

1. function([member1, member2])

2. function(
       [member1, member2]
   )

3. function([
       member1,
       member2,
   ])

and for a call with a trailing collection literal:

1. function(argument1, [member1, member2])

2. function(
       argument1, [member1, member2]
   )

3. function(argument1, [
       member1,
       member2,
   ])

4. function(
       argument1,
       [
           member1,
           member2,
       ],
   )

[obi1kenobi]

(resulting in flake8 complaining about "E231 missing whitespace after ','")
black, version 19.10b1.dev5+gde6f4b1

Somewhat tangentially, is triggering E231 here considered a bug in Black, or is it intended behavior? I'm not sure if I should configure my flake8 to ignore E231 or fix it manually and wait for an updated black with the fix.

[pabelanger]

I too am hitting this, while I can setup flake8 to ignore, I'm curious which formatter is correct here.

2020-01-16 01:20:16.197638 | centos-8 | ./plugins/modules/vyos_command.py:216:72: E231 missing whitespace after ','
2020-01-16 01:20:16.197646 | centos-8 |         {"stdout": responses, "stdout_lines": list(to_lines(responses)),}

[blueyed]

@pabelanger

{"stdout": responses, "stdout_lines": list(to_lines(responses)),}

As far as I can tell that's a bug in black, and you should remove it manually there (black will not re-add it then).

[SpotlightKid]

As far as I can tell that's a bug in black

Is there a separate ticket for this? It sure is very annoying.

[zsol]

Yes, #1202