Fix toml parsing and bump toml from 0.10.0 to 0.10.1 #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
force-pushed
the
fix_toml_parsing
branch
from
a2bbe19
to
e2e1e54
Compare
cooperlees
requested changes
Jun 15, 2020
The vim plugin directly calls parse_pyproject and skips the Click processing , but parse_pyproject assumed that it would only be used before Click processing and therefore made the config values click friendly. This moves the "make the values click friendly processing" into read_pyproject_toml which is only called by a Click callback.
ichard26
force-pushed
the
fix_toml_parsing
branch
from
e2e1e54
to
5d26286
Compare
cooperlees
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #637.
Resolves #1496.