-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flake8 W503 from docs as it is ignored by default #1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM! Will let our more stringent documentation overlords find something tho :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few things, they aren't related to your PR but hey @cooperlees I still found something! 😅
Other than that, looks good to me. Thanks! 🎉
.flake8
Outdated
@@ -1,5 +1,5 @@ | |||
[flake8] | |||
ignore = E203, E266, E501, W503 | |||
extend-ignore = E203, E266, E501 | |||
# line length is intentionally set to 80 here because black uses Bugbear | |||
# See https://github.com/psf/black/blob/master/README.md#line-length for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't make sense anymore since the docs were refactored.
# See https://github.com/psf/black/blob/master/README.md#line-length for more details | |
# See https://github.com/psf/black/blob/master/docs/the_black_code_style.md#line-length for more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the link at line 35 of docs/compatible_configs.md
to https://github.com/psf/black/blob/master/docs/the_black_code_style.md#how-black-wraps-lines
. (you can't comment on non modified code using the PR review UI 🙁)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I applied the suggested changes.
Is it possible that you forgot to remove W503 from the official docs? |
Maybe have a look at the master documentation. The changes will go live on the stable (and default) branch on a new release. |
Suspect regression. Using v 4.0.1 (Gentoo X86_64). Having just installed black (v22.1.0), reformatting produced multiple W503 messages. Attempted to utilize extended-ignore and reloaded/rescanned project. Warnings persisted. I ensured no W503/W504 ignores were present in code or configuration. Only after adding explicitly W503 to extended-ignore would flake8 be satisfied. |
I'm on black 22.1.0, Python 3.10 (macOS M1 ARM) and I can't remove the
|
Fixes #1660