Document some culprits with pre-commit #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Oct 23, 2020
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ichard26
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Looks good! I personally would like an explanation to why --exclude/--include can't be depended on when using pre-commit to be added but I don't care enough to press "request changes" instead.
Thanks for taking some time to work on this @Bibo-Joshi!
ichard26
added
T: documentation
I thought about that, but trying to give a short explanation might actually be more confusing. One could just link to the two issues, but that's not too nice to have in the documentation … |
noxan
pushed a commit
to noxan/black
that referenced
this pull request
Jun 6, 2021
* Document some culprits with pre-commit * make pre-commit happy * don't use monospace for black & pre-commit Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * make pre-commit happy again Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documentation about version control integration in hopes of preventing duplicatos of #1778 and #1773 :)