Add black Dockerfile
#1916
Merged
Add black Dockerfile
#1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build a `black` container based on python3-slim - Test: `docker build --network-host --tag black .` ```console cooper-mbp1:black cooper$ docker image ls REPOSITORY TAG IMAGE ID CREATED SIZE black latest 0c7636402ac2 4 seconds ago 332MB ``` Addresses part of #1914
|
Retested and rebased.
https://hub.docker.com/repository/docker/cooperlees/black/tags?page=1&ordering=last_updated |
|
When we land this I will look to automate a docker push + tagging for people to use (similar to bandersnatch) |
|
I'm sorry but I won't be able to review this since I have never used docker ... tip-toes away awkwardly |
gliptak
reviewed
Apr 3, 2021
There was a problem hiding this comment.
to decrease layer size consider multi-stage setup or setup like
FROM python:3-slim
RUN mkdir /src
COPY . /src/
RUN cd /src && pip install --upgrade pip setuptools wheel && apt update && apt install -y git && pip install --no-cache-dir .[colorama,d] && rm -rf /src && apt remove -y git && apt autoremove -y && rm -rf /var/lib/apt/lists/*
CMD ["black"]
TBBle
reviewed
Apr 4, 2021
Dockerfile
Outdated
| @@ -0,0 +1,10 @@ | |||
| FROM python:3-slim | |||
|
|
|||
| RUN pip install --upgrade pip setuptools wheel | |||
There was a problem hiding this comment.
Perhaps also use --no-cache-dir here?
- Combine the commands all into 1 RUN to down the size - Get to 65.98 MB image size now: https://hub.docker.com/repository/docker/cooperlees/black/tags?page=1&ordering=last_updated
gliptak
reviewed
Apr 4, 2021
Dockerfile
Outdated
| && pip install --no-cache-dir .[colorama,d] \ | ||
| && rm -rf /src \ | ||
| && apt remove -y git \ | ||
| && apt autoremove -y |
There was a problem hiding this comment.
maybe add && rm -rf /var/lib/apt/lists/*
Closed
|
I had a quick look at the current state, and apart from I shortened this list by adding That also cut 10s off the build by reducing the amount of stuff apt had to download, but the vast majority of time spent was in installing git, and it's not obvious why we need git installed here. Is it just a Deleting `/root/.cache`?For some reason,
I initially thought this would be fixed by Resulting layer tarstream non-directory entries: I reckon that's as-minimal a layer as one could get from the python:3-slim base image. At this point, all the changes in Resulting Dockerfile: FROM python:3-slim
RUN mkdir /src
COPY . /src/
RUN pip install --no-cache-dir --disable-pip-version-check --upgrade pip setuptools wheel \
&& apt update && apt install --no-install-recommends -y git \
&& cd /src \
&& pip install --no-cache-dir --disable-pip-version-check .[colorama,d] \
&& rm -rf /src \
&& apt remove --purge -y git \
&& apt autoremove --purge -y \
&& rm -rf /var/lib/apt/lists/* \
&& rm -rf /root/.cache
CMD ["black"] |
|
Ok, I feel I've waited long enough and had enough help from people. I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blackcontainer based on python3-slimdocker build --network-host --tag black .Addresses part of #1914