Add Docker Github Action #2086
Add Docker Github Action #2086
Conversation
- Build and upload arm64 + amd64 black images on push to master This will need a `DOCKERHUB_USERNAME` and `DOCKERHUB_TOKEN` secrets set by someone with access.
cooperlees
added
T: enhancement
|
Do we have a I'm torn on the News/Changelog entry - can add if people think we should. |
|
@cooperlees we have python and pyfound orgs. psf is too short for a docker hub org name. |
|
@cooperlees I added your user to the pyfound org on docker hub if you'd like to publish there. |
| on: | ||
| push: | ||
| branches: | ||
| - "master" |
There was a problem hiding this comment.
Do we want to rename our master branch to main? It's quite easy nowadays (see https://github.com/github/renaming). This isn't blocking this PR but this reference reminded me that we should probably do this.
There was a problem hiding this comment.
Yeah we should. Does it "rebase" / update nicely for people with existing checkouts etc? If so,. I can do now.
There was a problem hiding this comment.
No unfortunately:
Also, GitHub does not perform any redirects if users perform a git pull for the previous branch name
There was a problem hiding this comment.
@cooperlees feel free to merge this when you feel it's ready
Need secrets added before I can merge. Do you have access? |
|
Nope, https://github.com/psf/black/settings 404s for me. It might be just Lukasz. |
Bummer - Once secrets are added, we can merge this. |
This will need a
DOCKERHUB_USERNAMEandDOCKERHUB_TOKENsecrets set by someone with access.Fixes #1914