Add test requirements to Pipfile[.lock] & bump deps #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this development environment / requirements situation is a mess, let's at least make it consistent. We're effectively supporting two modes of development in this project, 1) tox based dev commands (e.g. `tox -e fuzz`) that are dead simple to use, and 2) manual dev commands (e.g. `pytest -n auto`) that give more control and are usually faster. Right now the Pipfile.lock based development environment is incomplete missing the test requirements specified in ./test_requirements.txt. This is annoying since manual test commands (e.g. `pytest -k fmtonoff`) fail. Let's fix this by making Pipfile.lock basically a "everything you need" requirements file (fuzzing not included since running it locally is not something common). Oh and let's bump some documentation deps (and bring some requirements across .pre-commit-config.yaml, Pipfile, and docs/requirement.txt in alignment again). Don't worry, I tested these changes so they should be fine (hopefully!).
ichard26
added
C: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this development environment / requirements situation might be a mess,
let's at least make it consistent. We're effectively supporting two
modes of development in this project, 1) tox based dev commands
(e.g.
tox -e fuzz) that are dead simple to use, and 2) manual devcommands (e.g.
pytest -n auto) that give more control and are usuallyfaster.
Right now the Pipfile.lock based development environment is incomplete
missing the test requirements specified in ./test_requirements.txt.
This is annoying since manual test commands (e.g.
pytest -k fmtonoff)fail. Let's fix this by making Pipfile.lock basically a
"everything you need" requirements file (fuzzing not included since
running it locally is not something common).
Oh and let's bump some documentation deps (and bring some requirements
across .pre-commit-config.yaml, Pipfile, and docs/requirement.txt in
alignment again). Don't worry, I tested these changes so they should
be fine (hopefully!).
Resolves #2410.