fix: run pypi upload from published draft releases #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Part of me wants to consolidate the OS native binaries and PyPI build+ upload workflows into one file, but this fixes a possible pitfall with the release system. This is already a win. Thanks @onerandomusername! You're awesome!
|
Just noticed, the docker workflow also uses created, and not released. |
|
I think its fixed now, also checked logs and it didn't run either. @ichard26 as you had to push to pypi manually, there is also not a published docker image for this release. https://hub.docker.com/r/pyfound/black/tags?page=1&ordering=last_updated |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes pypi_upload.yml not running when @ichard26 published a draft release to release 21.8b0.
Documentation is here, https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release, and since upload_binary ran, with this:
black/.github/workflows/upload_binary.yml
Lines 3 to 5 in a8b4665
changing the trigger for pypi_upload.yml to same as the above should fix the problem.
Checklist - did you ...