Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow any Generics on mypy except in black_primer #2556

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Disallow any Generics on mypy except in black_primer #2556

merged 1 commit into from
Oct 22, 2021

Conversation

nipunn1313
Copy link
Contributor

@nipunn1313 nipunn1313 commented Oct 22, 2021 •
edited
Loading

Description

Only black_primer needs the disallowal - means we'll
get better typing everywhere else.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary? (should not be necessary)
  • Add / update tests if necessary? (not needed)
  • Add new / update outdated documentation? (not needed)

@nipunn1313
Disallow any Generics on mypy except in black_primer
35133c0 
Only black_primer needs the disallowal - means we'll
get better typing everywhere else.
ichard26
ichard26 approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Oct 22, 2021
@JelleZijlstra JelleZijlstra merged commit da8a5bb into psf:main Oct 22, 2021
@nipunn1313 nipunn1313 deleted the mypy_any_generics branch October 22, 2021 02:58
JelleZijlstra pushed a commit that referenced this pull request Nov 16, 2021
@nipunn1313 @JelleZijlstra
Disallow any Generics on mypy except in black_primer (#2556)
b13c652 
Only black_primer needs the disallowal - means we'll
get better typing everywhere else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26 ichard26 approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nipunn1313 @ichard26 @JelleZijlstra