Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dump docs deps and pre-commit hooks #2676

Merged
merged 2 commits into from Dec 15, 2021
Merged

Conversation

ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Dec 6, 2021

Description

It's been a while since I last checked these pins.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary? -> n/a
  • Add / update tests if necessary? -> n/a
  • Add new / update outdated documentation? -> seems fine to me.

@ichard26 ichard26 added C: dependencies skip news Pull requests that don't need a changelog entry. labels Dec 6, 2021
@@ -41,7 +41,7 @@ repos:
- flake8-simplify

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.910
rev: v0.910-1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of weird but it does seem to exist

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran pre-commit autoupdate 🤷

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add pre-commit + one of the requirements updaters to hit these files? (Can be separate PR)

@MarcoGorelli
Copy link
Contributor

A bunch of projects are using pre-commit.ci for this, which comes with a regular autoupdate built-in - for what my suggestion's worth, I really recommend it!

@ichard26
Copy link
Collaborator Author

Yeah, we'll have to look into it as I'm not sure whether pre-commit.ci will play nicely with our local black hook. I'm down to add dependabot for docs/requirements.txt and test_requirements.txt though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: dependencies skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants