Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont skip formatting #%% #2919

Merged
merged 6 commits into from Mar 21, 2022
Merged

dont skip formatting #%% #2919

merged 6 commits into from Mar 21, 2022

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Mar 14, 2022

Description

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

closes #2588

@github-actions
Copy link

@github-actions github-actions bot commented Mar 14, 2022 •
edited

diff-shades reports zero changes comparing this PR (e8ee4d5) to main (fa7f015).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Mar 14, 2022

This needs to go in the preview style.

@MarcoGorelli
Copy link
Contributor Author

@MarcoGorelli MarcoGorelli commented Mar 14, 2022 •
edited

This needs to go in the preview style.

Thanks @JelleZijlstra , I've given this a go

Wasn't sure about BlackBaseTestCase.assertFormatEqual though - which value of preview should that have? just realised I can use self.mode.preview, please ignore that question

@MarcoGorelli
Copy link
Contributor Author

@MarcoGorelli MarcoGorelli commented Mar 21, 2022

gentle ping

JelleZijlstra
JelleZijlstra reviewed Mar 21, 2022
View changes
tests/data/comments8.py Outdated
x = """
a really long string
"""
lcomp3 = [
Copy link
Collaborator

@JelleZijlstra JelleZijlstra Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we shorten this code? The test can focus on just #%%, so no need for everything else.

Copy link
Contributor Author

@MarcoGorelli MarcoGorelli Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I was meaning it to be a --preview version of comments3.py - but shortening it and just testing # %% seems fine

JelleZijlstra
JelleZijlstra reviewed Mar 21, 2022
View changes
tests/data/comments8.py Outdated
)


#%%
Copy link
Collaborator

@JelleZijlstra JelleZijlstra Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an input comment that already has a space

@JelleZijlstra JelleZijlstra merged commit f87df0e into psf:main Mar 21, 2022
38 checks passed
intgr
intgr reviewed Mar 29, 2022
View changes
Copy link

@intgr intgr left a comment

The change log does a poor job explaining what a "code cell separator" is to people who haven't heard it

@ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Mar 29, 2022 •
edited

Feel free to PR a change to improve it then! ^^ unless you don't know what it is, in which case .. uhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr

@JelleZijlstra JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

black didn't format the cell note
4 participants
@MarcoGorelli @JelleZijlstra @ichard26 @intgr