Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parentheses from except clauses #2939

Merged
merged 6 commits into from Mar 26, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 18, 2022

Description

Closes #2937. As described in the issue we want to remove redundant parentheses from except clauses.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

src/black/mode.py Outdated Show resolved Hide resolved
@github-actions
Copy link

@github-actions github-actions bot commented Mar 18, 2022

diff-shades reports zero changes comparing this PR (4da6d57) to main (14d84ba).


What is this? | Workflow run | diff-shades documentation

tests/data/remove_except_parens.py Show resolved Hide resolved
tests/data/remove_except_parens.py Show resolved Hide resolved
@jpy-git jpy-git requested a review from JelleZijlstra Mar 23, 2022
@JelleZijlstra JelleZijlstra self-assigned this Mar 24, 2022
Copy link
Collaborator

@ichard26 ichard26 left a comment

I feel a bit uneasy merging formatting changes without a fully operational diff-shades integration, but this looks fine to me 🙂

Thanks again for all of your work!

@JelleZijlstra JelleZijlstra merged commit bd1e980 into psf:main Mar 26, 2022
38 checks passed
@jpy-git jpy-git deleted the remove_except_parens branch Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants