Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid magic-trailing-comma in single-element subscripts #2942

Merged
merged 7 commits into from Mar 24, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 18, 2022

Description

Closes #2918. Ignores magic-trailing-comma for single-element subscripts.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

src/black/lines.py Outdated Show resolved Hide resolved
@github-actions
Copy link

@github-actions github-actions bot commented Mar 18, 2022

diff-shades reports zero changes comparing this PR (b3afa72) to main (5379d4f).


What is this? | Workflow run | diff-shades documentation

@jpy-git jpy-git marked this pull request as draft Mar 18, 2022
@jpy-git jpy-git changed the title Avoid magic-trailing-comma in single tuple type Avoid magic-trailing-comma in single-element subscripts Mar 18, 2022
@jpy-git jpy-git marked this pull request as ready for review Mar 18, 2022
@Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Mar 19, 2022

Will it be possible to enable this without also turning on the experimental string processing?

@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Mar 19, 2022

No, preview mode is currently planned to be a single flag for everything.

@jpy-git jpy-git requested a review from JelleZijlstra Mar 23, 2022
@JelleZijlstra JelleZijlstra merged commit 3800ebd into psf:main Mar 24, 2022
38 checks passed
@ichard26
Copy link
Collaborator

@ichard26 ichard26 commented Mar 24, 2022

Congrats on your first contribution if my memory serves me correctly @jpy-git :D 🎉

Thanks for all of the great work -- sorry I haven't found the cycles to review 'em. Jelle's always around tho (thanks Jelle!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants