Avoid magic-trailing-comma in single-element subscripts #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
reviewed
Mar 18, 2022
jpy-git
changed the title
|
Will it be possible to enable this without also turning on the experimental string processing? |
|
No, preview mode is currently planned to be a single flag for everything. |
JelleZijlstra
reviewed
Mar 23, 2022
JelleZijlstra
approved these changes
Mar 24, 2022
|
Congrats on your first contribution if my memory serves me correctly @jpy-git :D Thanks for all of the great work -- sorry I haven't found the cycles to review 'em. Jelle's always around tho (thanks Jelle!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Closes #2918. Ignores magic-trailing-comma for single-element subscripts.
Checklist - did you ...