Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntelliJ docs on external tools and file watcher #3365

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Add IntelliJ docs on external tools and file watcher #3365

merged 3 commits into from
Jan 14, 2023

Conversation

ruslaniv
Copy link
Contributor

Revert deleted documentation on setting up Black using IntelliJ external tool or file watcher utilities

Issue: #3271

Description

Add documentation section on how to set up black in IntelliJ products using either File Watcher or External Tools utilities

Checklist

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@ruslaniv
Add IntelliJ docs on external tools and file watcher
2c3e402 
Revert deleted documentation on setting up Black using IntelliJ external tool or file watcher utilities
@ichard26 ichard26 added T: documentation Improvements to the docs (e.g. new topic, correction, etc) skip news Pull requests that don't need a changelog entry. C: integrations Editor plugins and other integrations labels Nov 1, 2022
felix-hilden
felix-hilden previously requested changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. The content does look good, although Prettier needs to be satisfied. In any case, thanks for re-introducing this! 🙏

ichard26
ichard26 approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for taking so long to land this.

@ichard26 ichard26 dismissed felix-hilden’s stale review January 14, 2023 18:30

I applied Prettier's changes, lint CI passes now.

@ichard26 ichard26 merged commit d4ff985 into psf:main Jan 14, 2023
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
@ruslaniv @ichard26 @hugovk
Add IntelliJ docs on external tools and file watcher (psf#3365)
269cad6 
Revert deleted documentation on setting up Black using IntelliJ
external tool or file watcher utilities. These are still worth keeping
because some peole might not want to use a third-party plugin or
install Blackd's extra dependencies.

Co-authored-by: Richard Si <sichard26@gmail.com>
@ichard26 ichard26 mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26 ichard26 approved these changes

@felix-hilden felix-hilden felix-hilden left review comments

Assignees
No one assigned
Labels
C: integrations Editor plugins and other integrations skip news Pull requests that don't need a changelog entry. T: documentation Improvements to the docs (e.g. new topic, correction, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruslaniv @felix-hilden @ichard26