Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not move docker latest_release tag for Pre-Releases #3461

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

cooperlees
Copy link
Collaborator

  • When we do a pre-release lets not move the latest_release tag
    • This tag should only move on official real releases

Fixes #3453

Would love any ideas on how to test this ...

- When we do a pre-release lets not move the latest_release tag
  - This tag should only move on official real releases

Fixes #3453
@cooperlees cooperlees added T: bug Something isn't working C: packaging Installation and packaging of Black C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Dec 19, 2022
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (c3ba192) to main (cd9fef8).


What is this? | Workflow run | diff-shades documentation

Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the GitHub Webhooks documentation at all, but this looks about right.

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Dec 20, 2022
@ichard26 ichard26 marked this pull request as draft December 20, 2022 01:52
@ichard26
Copy link
Collaborator

We also need to block the stable job from the PyPI workflow from running on a prerelease. That would be easy enough to test and I'll do that soon.

@cooperlees cooperlees marked this pull request as ready for review December 20, 2022 02:07
@cooperlees cooperlees merged commit 9ce7572 into main Dec 20, 2022
@cooperlees cooperlees deleted the docker_ci branch December 20, 2022 02:08
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
* Do not move docker `latest_release` tag for Pre-Releases

- When we do a pre-release lets not move the latest_release tag
  - This tag should only move on official real releases

Fixes psf#3453

* Make it prettier - TIL we format our yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases C: packaging Installation and packaging of Black skip news Pull requests that don't need a changelog entry. T: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker latest_release is pointing to an alpha version
2 participants