Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix this import, it's blib2to3.pgen2.driver, not blib2to3.driver. #3546

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Fix this import, it's blib2to3.pgen2.driver, not blib2to3.driver. #3546

merged 1 commit into from
Feb 4, 2023

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Feb 4, 2023

I'm not sure why mypy doesn't complain.

This was found while I was playing with Pytype on blib2to3.

@ichard26 ichard26 added the skip news Pull requests that don't need a changelog entry. label Feb 4, 2023
ichard26
ichard26 approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

diff-shades reports zero changes comparing this PR (87ed9b3) to main (b0d1fba).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra
Copy link
Collaborator

Mypy doesn't catch it because we have ignore_missing_imports = True for blib2to3 in mypy.ini. It might be worth checking if we can remove some of that.

@JelleZijlstra JelleZijlstra merged commit dd0e912 into psf:main Feb 4, 2023
@yilei yilei deleted the typecheck branch March 17, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichard26 ichard26 ichard26 approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yilei @JelleZijlstra @ichard26