Move coverage configurations to pyproject.toml
#3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/test.yml
Outdated
| @@ -62,7 +62,7 @@ jobs: | |||
| if: | |||
| github.repository == 'psf/black' && matrix.os == 'ubuntu-latest' && | |||
| !startsWith(matrix.python-version, 'pypy') | |||
| uses: AndreMiras/coveralls-python-action@v20201129 | |||
| uses: AndreMiras/coveralls-python-action@develop | |||
There was a problem hiding this comment.
We should pin to a specific version for security.
There was a problem hiding this comment.
Yeah, I'd also prefer to depend on dependabot to update this ... Is there a feature you needed in develop tag / branch?
There was a problem hiding this comment.
Tags are mutable, if we care about security don't we need a hash rather than v20201129?
There was a problem hiding this comment.
Make sense, updated to commit id.
cooperlees
approved these changes
Sep 1, 2023
|
Do we want a change log here? I don't feel we need one ... |
|
Thanks for the PR @jnhyperion, congrats on your first PR here! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
.coveragercis no longer needed since librarycoveragealready support configurations inpyproject.toml.