Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that preview/unstable features are documented #4187

Merged
merged 4 commits into from Jan 31, 2024

Conversation

JelleZijlstra
Copy link
Collaborator

In #4096 I added a list of current preview/unstable features to the docs. I think
this is important for publicizing what's in our preview style. This PR adds an
automated test to ensure the list stays up to date in the future.

This doesn't work with pre-commit (which is why I'm making this a draft). Haven't been able to figure out a way to fix that. I considered making it a unit test instead, but that will probably get redistributors unhappy.

In psf#4096 I added a list of current preview/unstable features to the docs. I think
this is important for publicizing what's in our preview style. This PR adds an
automated test to ensure the list stays up to date in the future.
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Jan 28, 2024
Copy link

@Pozaranch14 Pozaranch14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@JelleZijlstra JelleZijlstra marked this pull request as ready for review January 31, 2024 04:26
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I think if you want pre-commit to work you have to do repo: local (and also probably avoid any non-stdlib deps)

@hauntsaninja hauntsaninja merged commit cca3c0f into psf:main Jan 31, 2024
43 checks passed
@JelleZijlstra JelleZijlstra deleted the testpreview branch January 31, 2024 06:22
@JelleZijlstra
Copy link
Collaborator Author

Thanks for reviewing!

I think if you want pre-commit to work you have to do repo: local (and also probably avoid any non-stdlib deps)

I tried that, but the dependency on black.mode was hard to get rid of :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants