Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --safe work for Python2.7 syntax, by using typed_ast #840

Merged
merged 1 commit into from May 8, 2019
Merged

Make --safe work for Python2.7 syntax, by using typed_ast #840

merged 1 commit into from May 8, 2019

Conversation

fried
Copy link
Contributor

@fried fried commented May 7, 2019

Replace ast with typed_ast
Update all python2 tests to use safe checks.
Remove fast vs safe test for blackd, because it was a non-test with typed_ast

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @fried.

@graingert
Copy link
Contributor

@ambv does this mean we can do: #26 (comment)

@paugier paugier mentioned this pull request Oct 29, 2019
jlaasonen added a commit to ElectronicBabylonianLiterature/ebl-api that referenced this pull request Sep 15, 2020
We need to use a version before
psf/black#840
since typed_ast does not work on Pypy.
jlaasonen added a commit to ElectronicBabylonianLiterature/ebl-api that referenced this pull request Sep 15, 2020
* Add Github workflow for Black

* Add black as dev depencency

We need to use a version before
psf/black#840
since typed_ast does not work on Pypy.

* Format all files

* Use same version of Black in pip and workflow

* Delete workflow

* Update readme

* Add black check to Travis

* Use newer Pypy on Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants