Fix async blackd tests which won't fail currently #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks. |
florczakraf
pushed a commit
to florczakraf/black
that referenced
this pull request
Aug 27, 2019
florczakraf
pushed a commit
to florczakraf/black
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #691, I discovered that I couldn't get
blackdtests to fail in their current form (e.g. basic sanity check asserting1 == 2wouldn't fail the test suite).I refactor the tests for
blackdinto their ownAioHTTPTestCasewhich uses abstractions documented here fromaiohttp. Now, tests fail reliably when they are forced to fail or when there's a legit logical error.I also fix an exception that is thrown when no event loop is present in
event_loop. Additionally, Iraiseinskip_if_exceptionwhen an exception that shouldn't cause the test to be skipped is caught.