Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub email visibility failure message #1

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

msuozzo
Copy link
Contributor

@msuozzo msuozzo commented Nov 3, 2020

The previous link didn't contain the option necessary to make the email public. While the email settings page may need to be edited as well, the current github UI contains a pointer from the newly linked "Public email" section to the email settings page so users should be better guided to do the right update.

The previous link didn't contain the option necessary to make the email public. While the email settings page may need to be edited as well, the current github UI contains a pointer from the newly linked "Public email" section to the email settings page so users should be better guided to do the right update.
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berkerpeksag berkerpeksag merged commit 5e6e7b4 into psf:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants