Remove use of utcnow #290
Merged
Remove use of utcnow #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to note: this is the only library that |
|
@pganssle Can you please rebase the master? |
This removes the use of utcnow to avoid deprecation warnings, though ideally this would be fixed instead by switching over to using aware datetimes instead.
|
@frostming Done. |
frostming
reviewed
Jun 1, 2023
frostming
reviewed
Jun 1, 2023
frostming
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utcnowwill be deprecated in Python 3.12. In anticipation of this, it would be good to switch over your use ofdatetime.utcnowto use actual timezone-aware datetimes.There are two commits in this PR. The first one replaces all uses of
utcnowwith drop-in equivalents, but doesn't solve the underlying problem. The second one converts all the use ofdatetimethat I found to using aware datetimes instead of naïve ones. I think accepting that one would be preferable.