Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialize: remove v1 and v2 formats #310

Merged
merged 3 commits into from
Jun 1, 2023
Merged

serialize: remove v1 and v2 formats #310

merged 3 commits into from
Jun 1, 2023

Conversation

woodruffw
Copy link
Member

Closes #309.

@woodruffw woodruffw requested a review from frostming June 1, 2023 04:21
@woodruffw woodruffw self-assigned this Jun 1, 2023
@frostming
Copy link
Contributor

I think it may be a good idea to refactor a bit to extract the serialization/deserialization logic to its own class, instead of mixing them together. We can do it in the following PRs.

@woodruffw
Copy link
Member Author

woodruffw commented Jun 1, 2023 •
edited

I think it may be a good idea to refactor a bit to extract the serialization/deserialization logic to its own class, instead of mixing them together. We can do it in the following PRs.

Yeah, sounds good. I need to do a little more cleanup in this PR but it should be ready in a moment.

Edit: done.

@woodruffw woodruffw merged commit 6aba616 into master Jun 1, 2023
17 checks passed
@woodruffw woodruffw deleted the rm-old-cache-formats branch June 1, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Remove serialize._loads_v1 and _loads_v2
2 participants
@woodruffw @frostming