Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support of Python older than 3.7 #312

Merged
merged 3 commits into from
Jun 8, 2023
Merged

feat: drop support of Python older than 3.7 #312

merged 3 commits into from
Jun 8, 2023

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frostming
Copy link
Contributor Author

we have to make such change in a 0.14.0 release

@woodruffw
Copy link
Member

we have to make such change in a 0.14.0 release

That's fine by me -- IMO we technically can make it with a patch as well since we're pre-1.0, but I don't have any preference and doing it with 0.14.0 is probably clearer.

@dimbleby
Copy link
Contributor

dimbleby commented Jun 7, 2023

python 3.7 goes eol at the end of the month - it would not be unreasonable to drop support for that too in the next release

@woodruffw
Copy link
Member

python 3.7 goes eol at the end of the month - it would not be unreasonable to drop support for that too in the next release

One of CacheControl's major users is pip, so we probably need to be slightly more conservative than Python's own EOL schedule.

The current pip support policy is to support any Python version with more than 5% of PyPI's total downloads: https://pip.pypa.io/en/stable/development/release-process/#python-support-policy

@dimbleby
Copy link
Contributor

dimbleby commented Jun 7, 2023

Of course whether you want to continue to support python 3.7 is up to maintainers here: I just wanted to check that you weren't about to drop python 3.6 and then a week later go "oops, we really ought to have dropped python 3.7 at the same time".

FWIW it seems to me that pip's policies are pip's problem! but if you all don't find it burdensome to go along with them then all power to you.

@woodruffw
Copy link
Member

FWIW it seems to me that pip's policies are pip's problem! but if you all don't find it burdensome to go along with them then all power to you.

Agreed 🙂 -- I see it as a balance between courtesy for a downstream and our own development experience. The jump from 3.6 to 3.7 is pretty big in terms of __future__ support and type hint functionality whereas 3.7 to 3.8 is a bit more incremental, so I'm (personally) okay with not making more hops.

@frostming
Copy link
Contributor Author

Agree, we won't drop Python 3.7 shortly.

@frostming frostming merged commit d404a91 into master Jun 8, 2023
15 checks passed
@frostming frostming deleted the py37plus branch June 8, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants