Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging (issue #92) #93

Merged
merged 3 commits into from
Nov 25, 2015
Merged

Adding logging (issue #92) #93

merged 3 commits into from
Nov 25, 2015

Conversation

toolforger
Copy link
Contributor

First commit is a toe in the water: cache bypass decisions are logged.

PR created so we can discuss whether that's the right direction to take.
I have no idea about testing this. I'm sceptical about testing logging, because it tends to be both volatile and inconsequential so the gains of testing are marginal, but I'm happy to follow whatever the policy is.

First commit is a toe in the water: cache bypass decisions are logged.
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.56% when pulling 54e3304 on toolforger:add-logging into bc89ecc on ionrock:master.

@toolforger
Copy link
Contributor Author

Right, that global statement will go. (Not an error actually, but it's gratuitious.)

@landscape-bot
Copy link

Code Health
Repository health increased by 0.15% when pulling 075545f on toolforger:add-logging into bc89ecc on ionrock:master.

@ionrock
Copy link
Contributor

ionrock commented Sep 3, 2015

@toolforger Thanks for the PR. I merged this in the branch for #100. It should be merged into master when the doesitcache tool is finished.

@ionrock ionrock merged commit 075545f into psf:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants