Skip to content

Commit

Permalink
Fix Flask requirements and werkzeug imports
Browse files Browse the repository at this point in the history
  • Loading branch information
nateprewitt committed Oct 6, 2023
1 parent 61dc6c8 commit 3ac10b8
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 17 deletions.
12 changes: 2 additions & 10 deletions httpbin/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@
except ImportError: # werkzeug < 2.1
from werkzeug.wrappers import BaseResponse as Response

try:
from werkzeug.http import parse_authorization_header
except ImportError: # werkzeug < 2.3
from werkzeug.datastructures import Authorization
parse_authorization_header = Authorization.from_header

from flasgger import Swagger, NO_SANITIZER

from . import filters
Expand All @@ -53,6 +47,7 @@
H,
ROBOT_TXT,
ANGRY_ASCII,
parse_authorization_header,
parse_multi_value_header,
next_stale_after_value,
digest_challenge_response,
Expand Down Expand Up @@ -642,16 +637,13 @@ def redirect_to():
args_dict = request.args.items()
args = CaseInsensitiveDict(args_dict)

# We need to build the response manually and convert to UTF-8 to prevent
# werkzeug from "fixing" the URL. This endpoint should set the Location
# header to the exact string supplied.
response = app.make_response("")
response.status_code = 302
if "status_code" in args:
status_code = int(args["status_code"])
if status_code >= 300 and status_code < 400:
response.status_code = status_code
response.headers["Location"] = args["url"].encode("utf-8")
response.headers["Location"] = args["url"]

return response

Expand Down
21 changes: 16 additions & 5 deletions httpbin/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,14 @@
import time
import os
from hashlib import md5, sha256, sha512
from werkzeug.http import parse_authorization_header
from werkzeug.datastructures import WWWAuthenticate
from werkzeug.http import dump_header

try:
from werkzeug.http import parse_authorization_header
except ImportError: # werkzeug < 2.3
from werkzeug.datastructures import Authorization
parse_authorization_header = Authorization.from_header

from flask import request, make_response
from six.moves.urllib.parse import urlparse, urlunparse
Expand Down Expand Up @@ -466,9 +472,14 @@ def digest_challenge_response(app, qop, algorithm, stale = False):
]), algorithm)
opaque = H(os.urandom(10), algorithm)

auth = WWWAuthenticate("digest")
auth.set_digest('me@kennethreitz.com', nonce, opaque=opaque,
qop=('auth', 'auth-int') if qop is None else (qop,), algorithm=algorithm)
auth.stale = stale
values = {
'realm': 'me@kennethreitz.com',
'nonce': nonce,
'opaque': opaque,
'qop': dump_header(('auth', 'auth-int') if qop is None else (qop,)),
'algorithm': algorithm,
'stale': stale,
}
auth = WWWAuthenticate("digest", values=values)
response.headers['WWW-Authenticate'] = auth.to_header()
return response
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,13 @@ classifiers = [
"Programming Language :: Python :: 3.12",
]
dependencies = [
"Flask",
"flask >= 2.2.4",
"brotlicffi",
"decorator",
"flasgger",
'greenlet < 3.0; python_version<"3.12"',
'greenlet >= 3.0.0a1; python_version>="3.12.0rc0"',
'importlib-metadata; python_version<"3.8"',
"werkzeug >= 0.14.1",
"six",
]

Expand Down

0 comments on commit 3ac10b8

Please sign in to comment.