Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when using web builds, prevent console error #40

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

miketheman
Copy link
Member

It was annoying me, so it had to go.
And by go, I mean fixed.

Signed-off-by: Mike Fiedler miketheman@gmail.com

It was annoying me, so it had to go.
And by go, I mean fixed.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@ewdurbin
Copy link
Member

@miketheman can you detail what error this was causing? looks good to me otherwise!

@miketheman
Copy link
Member Author

Error in Console:

Failed to load resource: the server responded with a status of 404 (Not Found) manifest.json:1
GET http://localhost:8100/manifest.json 404 (Not Found)

Attempted to be loaded from

<link rel="manifest" href="manifest.json">

@ewdurbin
Copy link
Member

oh hey, very glad for this. I think it will make live updates much faster.

@ewdurbin ewdurbin merged commit 91b8376 into psf:main Apr 12, 2023
@miketheman miketheman deleted the fix-manifest branch April 12, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants