Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize new name of Graal-based Python as jitted #139

Merged
merged 1 commit into from Aug 25, 2022

Conversation

timfel
Copy link
Contributor

@timfel timfel commented Aug 25, 2022

sys.implementation.name was changed in recent Graal nightlies.

`sys.implementation.name` was changed in recent Graal nightlies.
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 0ef21a1 into psf:main Aug 25, 2022
@timfel timfel deleted the patch-1 branch August 25, 2022 18:22
@timfel
Copy link
Contributor Author

timfel commented Aug 25, 2022

thank you!

@vstinner
Copy link
Member

Defining if a Python implementation has a JIT or not became complicated. CPython 3.10 has an "opcode cache". CPython 3.11 now has "adaptative bytecode" which changes the bytecode after a few iterations.

It might help to implement a changepoint detection to decide if a benchmark looks steady or not.

My notes: https://vstinner.readthedocs.io/pypy_warmups.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants